Add stream support #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruss
force-pushed
the
add_stream_support
branch
from
b98ffb7 to
e45f2dd
Compare
kruss
force-pushed
the
add_stream_support
branch
2 times, most recently
from
ddce203 to
46f3258
Compare
Cleanup of feature names.
kruss
force-pushed
the
add_stream_support
branch
from
46f3258 to
6367c20
Compare
marcmo
reviewed
Feb 21, 2025
| let (_, header) = dlt_standard_header(&header_buf[storage_len..])?; | ||
|
|
||
| let message_len = storage_len + header.overall_length() as usize; | ||
| let mut message_buf = vec![0u8; message_len]; |
There was a problem hiding this comment.
better if we reuse the memory instead of allocating new memory on each call
marcmo
reviewed
Feb 21, 2025
Comment on lines
+25
to
+27
| tokio = { version = "1", features = ["full"], optional = true } | ||
| tokio-stream = { version = "0.1", optional = true } | ||
| tokio-util = { version = "0.7", optional = true } |
There was a problem hiding this comment.
not needed. only tokio is currently neede for your tests
marcmo
requested changes
Feb 21, 2025
There was a problem hiding this comment.
looks quite good!
let's investigate if we can add support for
https://rust-lang.github.io/async-book/05_streams/01_chapter.html
by implementing it ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #34 as a new feature 'stream', cleans up the already existing feature names to be more consistent in naming and increases the crate version to '0.20.0'.