ESP32 - fix jshCanWatch for ESP32 & ESP32S3 #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! And this definitely seems to fix it for you? This is an odd one as looking back this change was made 8 years ago! I'm amazed nobody noticed this earlier - you must have used setWatch in the past on ESP32 surely and it worked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setWatch on ESP32 and ESP32S3 retruns
WARNING: Unable to set watch. You may already have a watch on a pin with the same number (eg. A0 and B0), or this pin cannot be used with watchfor vaild pins,