[owmweather] prevent updating settings.updated when call to OWM fails #3876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrippling
reviewed
Jun 11, 2025
apps/owmweather/boot.js
Outdated
| @@ -10,14 +10,21 @@ | |||
| return settings.refresh * 1000 * 60 + 1; // +1 <- leave some slack | |||
| }; | |||
|
|
|||
| let onCompleted = function () { | |||
| let onCompleted = function (result) { | |||
There was a problem hiding this comment.
Nope. But that question made me realize I missed an error situation.
In lib.js, the parseWeather method returns undefined on success, or a string on error.
I've added checking that result and calling the appropriate callback based on it.
There was a problem hiding this comment.
Nice! I'm happy to merge but if you wanted there is the option of trimming down a bit too:
if (result === undefined) {
if (completionCallback) completionCallback();
} else {
- if (errorCallback) errorCallback(result);
+ throw result;
}
}).catch((e)=>{
if (errorCallback) errorCallback(e);
|
LGTM, one small comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: https://thinkpoop.github.io/BangleApps/?id=owmweather
In
boot.jsfunctiononCompleted, thesettings.updatedvalue is always updated, even if it's being called during error handing.Example:
GB gets disconnected.
OWMWeather tries to refresh, gets a timeout, sets settings.updated to now + 1hr.
GB gets reconnected.
OWMWeather checks settings.updated and thinks it doesn't need , even though the data is bad.