Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit of dsky_clock #3700

Merged
merged 28 commits into from
Dec 30, 2024
Merged

initial commit of dsky_clock #3700

merged 28 commits into from
Dec 30, 2024

Conversation

carlchan
Copy link
Contributor

DSKY Clock

This is a clockface inspired by the Apollo DSKY interface.

Features

  • battery level indicator (PROG indicator)
  • month (VERB indicator)
  • date (NOUN indicator)
  • Current local time (DATA 1)
  • UTC time (DATA 2)
  • Step counter (DATA 3)

Indicator lights are:

  • COMP ACTY (GPS/HRM active)
  • MSG (Messages waiting)
  • LOCK (Screen is locked)
  • BT (Bluetooth is disconnected)
  • BATT (Low battery or battery charging)
  • ALARM (Alarm is set)
  • STEP (Reached STEP goal))

This is my first watch face, may add features and customization later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name from dsky_clock.app.js to app.js to clear the sanitychecker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new review comment with some more instructions for this :)

apps/dsky_clock/metadata.json Outdated Show resolved Hide resolved
apps/dsky_clock/metadata.json Outdated Show resolved Hide resolved
apps/dsky_clock/metadata.json Show resolved Hide resolved
apps/dsky_clock/metadata.json Outdated Show resolved Hide resolved
apps/dsky_clock/app.js Outdated Show resolved Hide resolved
apps/dsky_clock/app.js Outdated Show resolved Hide resolved
apps/dsky_clock/app.js Outdated Show resolved Hide resolved
apps/dsky_clock/app.js Show resolved Hide resolved
@thyttan
Copy link
Collaborator

thyttan commented Dec 28, 2024

Some of the ui-elements seem to be drawn a bit further down compared to the icon on my watch (I think it may have to do with widgets and when the app height values are read maybe?):
image

But looks neat otherwise!

Edit: When resetting the watch with long press hardware button the ui looks right. But not when coming from Desktop Launcher (which opens dsky_clock by fast loading).

so that the layout doesn't account for the widget bar when `dsky_clock`
is fast loaded into.

Also handle the hardware button through the layout library instead of
`Bangle.setUI`. Also set `Bangle.CLOCK` directly.
@thyttan
Copy link
Collaborator

thyttan commented Dec 28, 2024

Refactored a bit and PR'd to your fork. Use it if you want! carlchan#1

@carlchan
Copy link
Contributor Author

Refactored a bit and PR'd to your fork. Use it if you want! carlchan#1

Fantastic! Thank you!

@thyttan
Copy link
Collaborator

thyttan commented Dec 29, 2024

If you want to we could merge now. Just say! :)

I'd suggest for a next version to look at another background color for the indicator field on the left that doesn't need to be dithered - since dithering massively hinders legibility of the text on the watch!

@carlchan
Copy link
Contributor Author

If you think it's ready, then yes please!

@thyttan
Copy link
Collaborator

thyttan commented Dec 29, 2024

Let's go ahead then - thanks for contributing your first app! 🎉

@thyttan thyttan merged commit 1e32d09 into espruino:master Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants