[AIClock] Added clkinfos #2349
Merged
[AIClock] Added clkinfos #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect it had to do with this (comment)? |
Yea true I simply copied things from BW -- now it should be fine :) |
|
Looks great, thanks for tweaking those icons too! If you're finding that you're duplicating that clkinfo navigation code for your clocks then we could always add that to the library as well? I guess at some point we could look at making the interaction mode configurable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds clkinfo to the AIClock. As I prefer touch events rather then gestures (which I use for pattern launch) I implemented it classical and not via
addInteractive.I also updated some "base" icons which are currently used by BWClock and AIClock as the coloring was for some reasons not correct -- now it seems to work fine for both clocks.