Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add elc test on madelung energy #4785

Merged
merged 1 commit into from
Dec 8, 2023
Merged

add elc test on madelung energy #4785

merged 1 commit into from
Dec 8, 2023

Conversation

schlaicha
Copy link
Contributor

@schlaicha schlaicha commented Sep 5, 2023 •
edited by reinaual
Loading

Fixes #4786

For neutral systems ELC-IC still seems to work perfectly fine.

Description of changes:

  • Improve testing of ELC using the Madelung energy

@schlaicha schlaicha mentioned this pull request Sep 5, 2023
Closed
@espressomd espressomd deleted a comment from espresso-ci Dec 8, 2023
@espressomd espressomd deleted a comment from espresso-ci Dec 8, 2023
@reinaual reinaual requested a review from jngrad December 8, 2023 15:05
jngrad
jngrad approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad jngrad added the automerge Merge with kodiak label Dec 8, 2023
@kodiakhq kodiakhq bot merged commit 898b4cb into espressomd:python Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Testcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ELC energies (and forces?) might be of by factor 2
3 participants
@schlaicha @jngrad @reinaual