Skip to content

Commit

Permalink
Encapsulate HDF5 module (#5031)
Browse files Browse the repository at this point in the history
Description of changes:
- bump version requirements of h5xx
- source h5xx via FetchContent instead of submodules
   - the ESPResSo repository can now be cloned without `--recursive`
   - the creation of GitHub releases no longer depends on third-party tools and can be fully automated
- hide hdf5 and h5xx header files and compiler flags from consumer targets
- fix portability issues revealed by newer compiler toolchains
  • Loading branch information
kodiakhq[bot] authored Jan 24, 2025
2 parents 74490c0 + a4a31f2 commit e0be7c7
Show file tree
Hide file tree
Showing 21 changed files with 580 additions and 418 deletions.
6 changes: 0 additions & 6 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,13 @@ stages:
- trying.tmp
before_script:
- git config --global --add safe.directory ${CI_PROJECT_DIR}
- git config --global --add safe.directory ${CI_PROJECT_DIR}/libs/h5xx
timeout: 1h
interruptible: true

.notification_job_template: &notification_job_definition
<<: *global_job_definition
image: ghcr.io/espressomd/docker/fedora:f7f8ef2c0ca93c67aa16b9f91785492fb04ecc1b
variables:
GIT_SUBMODULE_STRATEGY: none
GET_SOURCES_ATTEMPTS: 3
before_script:
- git config --global --add safe.directory ${CI_PROJECT_DIR}
Expand All @@ -32,7 +30,6 @@ stages:
- no-cuda

variables:
GIT_SUBMODULE_STRATEGY: recursive
GET_SOURCES_ATTEMPTS: 3
CCACHE_DIR: /cache
CCACHE_MAXSIZE: 100G
Expand All @@ -49,14 +46,11 @@ style:
dependencies: []
before_script:
- git config --global --add safe.directory ${CI_PROJECT_DIR}
- git submodule deinit .
script:
- sh maintainer/CI/fix_style.sh
tags:
- espresso
- no-cuda
variables:
GIT_SUBMODULE_STRATEGY: none
artifacts:
paths:
- style.patch
Expand Down
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
[submodule "libs/h5xx"]
path = libs/h5xx
url = https://github.com/h5md/h5xx.git
Loading

0 comments on commit e0be7c7

Please sign in to comment.