-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add essl to component manager #9
Conversation
@mahavirj @tore-espressif PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ginkgm Please add entry for this component in .github/workflows/upload_component.yml
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to move tests here too?
e.g. https://github.com/espressif/esp-idf/blob/master/components/driver/test/test_spi_slave_hd.c
https://github.com/espressif/esp-idf/blob/master/components/driver/test/test_sdio.c
We are working on running unit tests in GitHub action, but it is not ready yet. As of now, we only build the tests
EDIT: See #13 . This PR runs test_app on our self-hosted runners
And let me know whether you are ready to merge |
8523370
to
e0ddf7a
Compare
e0ddf7a
to
56248a6
Compare
c390bf4
to
8953310
Compare
I think the target-test is too complicated to be in this repo. So I will only add a simple build test, to make sure the component can be build fine. |
8953310
to
7b908ac
Compare
@ginkgm could you please check the two static analysis warnings reported above? |
63ba00a
to
62a2c53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ginkgm Thank you for following this up.
I'm haven't worked with essl before, so I can't review properly.
Just make sure that the code compiles with esp-idf master
esp_serial_slave_link/include/esp_serial_slave_link/essl_sdio.h
Outdated
Show resolved
Hide resolved
9b7ad51
to
f270023
Compare
f270023
to
fe588a4
Compare
@tore-espressif @kumekay @mahavirj Please merge this MR if it's OK for you. There is basic build test for the source files. For the compatibilities, I tried with ESP-IDF master examples with slight changes. Those changes will be added to IDF master after this is merged. |
Moving this component from IDF to extra components, since it's upper layer component.
Tracking ESP-IDF commit: 4f1a9e436e