Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib3 2.2.0, requests-file 2.0.0 (PACMAN-794) #50

Closed
wants to merge 1 commit into from

Conversation

jiapei100
Copy link

Please describe your proposed PR and what it contains.

Impact

Please describe the impact of your PR and its function.

Related links

Please provide links to related issue, PRs etc.


Checklist

  1. Please provide the specific and clear title of the PR describing the change (eg. „Fix support for python versions >3.136“)
  2. Please provide related links (eg. Issue, related repository, etc...)

This entire section above can be deleted if all items are checked.

Copy link

github-actions bot commented Feb 4, 2024

Warnings
⚠️ The PR description looks very brief, please check if more details can be added.

👋 Welcome jiapei100, thank you for your first contribution to espressif/idf-component-manager project!

📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics.

Pull request review and merge process you can expect

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  4. If the change is approved and passes the tests it is merged into the default branch

🔁 You can re-run automatic PR checks by retrying the DangerJS action


⚠️ Deprecation Notice: This GitHub action is scheduled for removal in March 2024. We recommend migrating to the latest version available in the shared-github-danger project.

Generated by 🚫 dangerJS against 4dd9bda

@github-actions github-actions bot changed the title urllib3 2.2.0, requests-file 2.0.0 urllib3 2.2.0, requests-file 2.0.0 (PACMAN-794) Feb 4, 2024
@dobairoland
Copy link

I don't think this is a solution for your problem outlined in espressif/esp-idf#13102. It is just a workaround for you and probably cannot be accepted here. I'm not a component manager developer but I think those package version limits are there for a reason.

@kumekay
Copy link
Collaborator

kumekay commented Feb 15, 2024

@jiapei100 Thank you for contribution,

Unfortunately versions are locked due to issues with other packages, and this change cannot be accepted right now.
We are going to drop support for older pythons in the coming release next month and update the dependencies.

@kumekay kumekay closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants