Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disconnect btn not shown upon connect error #176

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

brianignacio5
Copy link
Collaborator

Description

Fix #165
Fix #173

Buttons should not be updated when there is a failed connection error in the Typescript live example.

Testing

Clone this branch and run npm run dev within examples/typescript. This will create a local server running at http://localhost:1234

  1. Connect on 1 tab. Connection should be successful.
  2. Open a new tab and try to connect. Connection should fail but buttons like disconnect should not be shown.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@brianignacio5 brianignacio5 self-assigned this Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 merged commit 4e7f682 into main Jan 13, 2025
1 check passed
@brianignacio5 brianignacio5 deleted the bugfix/failed-connect branch January 13, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant