Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark port optional #116

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Mark port optional #116

merged 1 commit into from
Nov 1, 2023

Conversation

balloob
Copy link
Contributor

@balloob balloob commented Oct 30, 2023

It was accidentally marked required. Code already assumes it's optional.

Introduced in 04e337d#r130045791

It was accidentally marked required. Code already assumes it's optional.
@brianignacio5
Copy link
Collaborator

Thanks @balloob Probably modified in the PR with options updated.

@brianignacio5 brianignacio5 merged commit 6e9ae9b into espressif:main Nov 1, 2023
1 check passed
@balloob balloob deleted the patch-3 branch November 4, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants