Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp_tinyusb): Pinned tinyusb task to the CPU1 by default #96

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Dec 3, 2024

esp_tinyusb component, v1.5.0

Requirements

A problem could be present in a high-loaded systems (with several interfaces) and when large amounts of data were being sent and received simultaneously, the dcd_event_xfer_complete event was not triggered.

Description

Pinned tinyusb FreeRTOS task to CPU1 by default in the dual-core systems.

Related

  • Releated to IDF-4552

Testing

N/A

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@tore-espressif
Copy link
Collaborator

tore-espressif commented Dec 3, 2024

@roma-jam

  • please add the change to CHANGELOG.md
  • Make sure it works as expected in single core system (ESP32-S2)

@roma-jam
Copy link
Collaborator Author

roma-jam commented Dec 3, 2024

@tore-espressif If we have the CI such as: Build and Run USB Test Application (which builds and runs the test_apps on esp32s2), does it counts that it works "as expected"?

Or you are talking about something else?

@tore-espressif
Copy link
Collaborator

does it counts that it works "as expected"?

Yes, that is actually enough :D Maybe just add a comment that it is OK top pin to CPU1 on single CPU system. The users might get confused

@roma-jam roma-jam force-pushed the fix/missing_irq_on_two_cores branch from 18b8841 to 8b78b7c Compare December 4, 2024 11:00
@roma-jam roma-jam self-assigned this Dec 4, 2024
@roma-jam roma-jam marked this pull request as ready for review December 4, 2024 11:05
@roma-jam roma-jam force-pushed the fix/missing_irq_on_two_cores branch from 8b78b7c to ea1165c Compare December 4, 2024 14:02
@roma-jam roma-jam marked this pull request as draft December 4, 2024 16:03
@roma-jam roma-jam added this to the esp_tinyusb v1.5.0 milestone Dec 5, 2024
@roma-jam roma-jam marked this pull request as ready for review December 6, 2024 08:57
@roma-jam roma-jam force-pushed the fix/missing_irq_on_two_cores branch from ea1165c to 7c4ccce Compare December 6, 2024 09:00
@roma-jam roma-jam merged commit 2038918 into master Dec 6, 2024
29 checks passed
@roma-jam roma-jam deleted the fix/missing_irq_on_two_cores branch December 12, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants