Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove libtinfo5 installation #36

Merged
merged 1 commit into from
May 21, 2024

Conversation

peter-marcisovsky
Copy link
Collaborator

Following up with a fix from idf-extra-components

@igrr
Copy link
Member

igrr commented May 21, 2024

@peter-marcisovsky FYI, I've reverted the update of clang-tidy-sarif. There is an issue with duplicate entries in the generated SARIF file. I'll submit a fix to clang-tidy-sarif and upgrade it later.

@peter-marcisovsky peter-marcisovsky force-pushed the ci/clang-tidy_workflow_fix branch from b06cd26 to 5348465 Compare May 21, 2024 16:28
@peter-marcisovsky peter-marcisovsky changed the title ci: remove libtinfo5 installation, upgrade clang-tidy-sarif ci: remove libtinfo5 installation May 21, 2024
Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peter-marcisovsky peter-marcisovsky merged commit ed82501 into master May 21, 2024
15 checks passed
@peter-marcisovsky peter-marcisovsky self-assigned this May 22, 2024
@peter-marcisovsky peter-marcisovsky deleted the ci/clang-tidy_workflow_fix branch December 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants