-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USB Host MSC: Add request sense feature #34
Conversation
85198b0
to
1033e50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @roma-jam PTAL too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick, otherwise LGTM!
1033e50
to
282194b
Compare
@roma-jam Coul you please take a look at the failing CI?
|
282194b
to
e98477d
Compare
@peter-marcisovsky Please let me know if we should wait for the CI pass or whether I can force merge 🥇 |
@tore-espressif we are only waiting for GitLab master branch sync to GH, to pass the CI. So This MR is ready to be merged |
@peter-marcisovsky @tore-espressif |
dc45521
to
e08deae
Compare
e08deae
to
07d9107
Compare
Closing IDF-9890
Added request sense feature for MCS driver.
After each BOT command execution a
CSW
is checked for possible errors. If an error is present in the MSC device abCSWStatus
is returned to the Host as non zero. Ref: USB Mass Storage Class – Bulk Only Transport table 5.3. But a current MSC Host driver does not allow the user to find out what is causing the error.This MR adds a feature to the MSC Host to issue a request sense to the MSC device each time, after checking
CSW
for errors. The request sense command returns specific error code. Ref: USB Mass Storage Class – UFI Command Specification Chapter 4.11 and Table 51