-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add copyright license check #15
Conversation
8697be1
to
e987e80
Compare
e987e80
to
705e4b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Should we added the changes also to a git workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was checking whether you need to update the years on the license if you are changing the license itself, not the actual code.
Found you it's ok the way as it is now. But, correct me if I am wrong.
Otherwise, LGTM.
Thanks for the reviews! @roma-jam what do you mean by
If you have pre-commit installed the check will run automatically, so there is no need to do anything extra |
@tore-espressif The same as you did here: #12? |
#12 added pre-commit run to CI. So this change will be automatically reflected in your local repo and also checked in CI |
Added copyright header check to pre-commit