fix(esp_tinyusb): Uninstall TinyUSB driver while external task is using #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roma-jam
changed the base branch from
master
to
feature/esp32p4_fs_phy_config
roma-jam
force-pushed
the
feature/tusb_task_test_apps
branch
from
ac9b94c to
bb9ab4a
Compare
roma-jam
commented
Jan 15, 2025
| } | ||
|
|
||
| /** | ||
| * @brief TinyUSB Teardown specific testcase |
There was a problem hiding this comment.
Suggested change
| * @brief TinyUSB Teardown specific testcase | |
| * @brief TinyUSB Task specific testcase |
| } | ||
|
|
||
| /** | ||
| * @brief TinyUSB Teardown specific testcase |
There was a problem hiding this comment.
Suggested change
| * @brief TinyUSB Teardown specific testcase | |
| * @brief TinyUSB Task specific testcase |
| /** | ||
| * @brief TinyUSB Teardown specific testcase | ||
| * | ||
| * Scenario: |
There was a problem hiding this comment.
Suggested change
| * Scenario: | |
| * Scenario: | |
| * 1. Install TinyUSB driver | |
| * 2. Wait tud_mount_cb() until TUSB_DEVICE_DELAY_MS | |
| * 3. Wait TUSB_DEVICE_DELAY_MS | |
| * 4. Teardown TinyUSB | |
| * 5. Release resources |
| * 2. Create external TinyUSB task for tud_task() | ||
| * 3. Wait tud_mount_cb() for TUSB_DEVICE_DELAY_MS | ||
| * 4. Wait TUSB_DEVICE_DELAY_MS | ||
| * 5. Teardwon TinyUSB |
There was a problem hiding this comment.
Suggested change
| * 5. Teardwon TinyUSB | |
| * 5. Teardown TinyUSB |
| } | ||
|
|
||
| /** | ||
| * @brief TinyUSB Teardown specific testcase |
There was a problem hiding this comment.
Suggested change
| * @brief TinyUSB Teardown specific testcase | |
| * @brief TinyUSB Task specific testcase |
| /** | ||
| * @brief TinyUSB Teardown specific testcase | ||
| * | ||
| * Scenario: |
There was a problem hiding this comment.
Suggested change
| * Scenario: | |
| * Scenario: | |
| * 1. Install TinyUSB driver | |
| * 2. Wait tud_mount_cb() until TUSB_DEVICE_DELAY_MS | |
| * 3. Wait TUSB_DEVICE_DELAY_MS | |
| * 4. Teardown TinyUSB | |
| * 5. Release resources |
| @@ -0,0 +1,16 @@ | |||
| # Configure TinyUSB, it will be used to mock USB devices | |||
There was a problem hiding this comment.
Suggested change
| # Configure TinyUSB, it will be used to mock USB devices | |
| # Configure TinyUSB |
| @@ -0,0 +1,16 @@ | |||
| # Configure TinyUSB, it will be used to mock USB devices | |||
There was a problem hiding this comment.
Suggested change
| # Configure TinyUSB, it will be used to mock USB devices | |
| # Configure TinyUSB |
| @@ -0,0 +1,16 @@ | |||
| # Configure TinyUSB, it will be used to mock USB devices | |||
There was a problem hiding this comment.
Suggested change
| # Configure TinyUSB, it will be used to mock USB devices | |
| # Configure TinyUSB |
roma-jam
commented
Jan 15, 2025
| * Scenario: | ||
| * 1. Install TinyUSB driver | ||
| * 2. Create external TinyUSB task for tud_task() | ||
| * 3. Wait tud_mount_cb() for TUSB_DEVICE_DELAY_MS |
There was a problem hiding this comment.
Suggested change
| * 3. Wait tud_mount_cb() for TUSB_DEVICE_DELAY_MS | |
| * 3. Wait tud_mount_cb() until TUSB_DEVICE_DELAY_MS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed error when esp_tinyusb is configured with
CONFIG_TINYUSB_NO_DEFAULT_TASK=yRelated
Prerequisites for dynamic TinyUSB configuration:
Testing
Added three additional test applications for two parameters
CONFIG_TINYUSB_NO_DEFAULT_TASKandCONFIG_TINYUSB_INIT_IN_DEFAULT_TASKTest Matrix:
CONFIG_TINYUSB_NO_DEFAULT_TASK=n,CONFIG_TINYUSB_INIT_IN_DEFAULT_TASK=n)CONFIG_TINYUSB_NO_DEFAULT_TASK=n,CONFIG_TINYUSB_INIT_IN_DEFAULT_TASK=y)CONFIG_TINYUSB_NO_DEFAULT_TASK=y)Checklist
Before submitting a Pull Request, please ensure the following: