Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Enable IDF 5.3 test app run in CI for esp32p4 #100

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

peter-marcisovsky
Copy link
Collaborator

Description

This MR Enables IDF 5.3 test app run in CI for esp32p4, as we were waiting for the docker image of the IDF 5.3 to update.
This update in IDF 5.3 adds support for esp32p4 ECO2 flashing.

Related

Testing

To pass this CI

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@peter-marcisovsky peter-marcisovsky force-pushed the ci/enalbe_idf_5.3_esp32p4 branch from 20c271a to 6020058 Compare December 6, 2024 15:56
@roma-jam
Copy link
Collaborator

roma-jam commented Dec 9, 2024

One nitpick about artifacts, we don't need /test_app/*/build_esp*/test_app_*.elf for the pytest.
Usually, *.elf is used for debugging, so we don't need to pass it as an artifact.

@peter-marcisovsky
Copy link
Collaborator Author

@roma-jam thx for checking, we have been passing elf flies as an artifact since the very beginning. But, yes, looks like we can remove it.

@peter-marcisovsky peter-marcisovsky force-pushed the ci/enalbe_idf_5.3_esp32p4 branch from 6020058 to 3fae6ce Compare December 9, 2024 08:58
@tore-espressif
Copy link
Collaborator

@roma-jam thx for checking, we have been passing elf flies as an artifact since the very beginning. But, yes, looks like we can remove it.

BTW, the .elf file is actually used by pytest in case there is 'abort' or similar failure. It will use the elf file to decode at which line the program aborted

@peter-marcisovsky
Copy link
Collaborator Author

@roma-jam looks like we should better leave the .elf files in the artifacts. I will revert the latest changes

@peter-marcisovsky peter-marcisovsky force-pushed the ci/enalbe_idf_5.3_esp32p4 branch from 3fae6ce to 29f3744 Compare December 9, 2024 10:06
@peter-marcisovsky peter-marcisovsky merged commit e5feb3f into master Dec 9, 2024
31 checks passed
@peter-marcisovsky peter-marcisovsky deleted the ci/enalbe_idf_5.3_esp32p4 branch December 12, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants