Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): Prevent overwriting of component properties in output file (IDFGH-13891) #14733

Merged

Conversation

viayie
Copy link
Contributor

@viayie viayie commented Oct 16, 2024

Description

While component_properties_text
correctly accumulated properties from all processed components, each iteration of the loop was overwriting the entire file content.

Move the file(WRITE ...) call outside the loop to ensure all accumulated component properties are written once, preserving information for all components.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Oct 16, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello viayie, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against bdf0821

@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 16, 2024
@github-actions github-actions bot changed the title fix(cmake): Prevent overwriting of component properties in output file fix(cmake): Prevent overwriting of component properties in output file (IDFGH-13891) Oct 16, 2024
While 'component_properties_text'
correctly accumulated properties from all processed components, each
iteration of the loop was overwriting the entire file content.

Move the file(WRITE ...) call outside the loop to ensure all accumulated
component properties are written once, preserving information for all
components.
@viayie viayie force-pushed the fix/component-write-properties branch from 856edda to bdf0821 Compare October 16, 2024 06:11
@viayie viayie marked this pull request as draft October 16, 2024 06:22
@viayie viayie marked this pull request as ready for review October 16, 2024 06:42
@fhrbata
Copy link
Collaborator

fhrbata commented Oct 16, 2024

Hello @viayie , LGTM, thank you for this improvement!

@dobairoland
Copy link
Collaborator

sha=bdf0821f976880a44100ccd140a6ce8bf8fef973

@dobairoland dobairoland added the PR-Sync-Merge Pull request sync as merge commit label Nov 11, 2024
@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: Selected for Development Issue is selected for development Status: Reviewing Issue is being reviewed labels Nov 11, 2024
@espressif-bot espressif-bot merged commit 542a5d2 into espressif:master Nov 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants