-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmake): Prevent overwriting of component properties in output file (IDFGH-13891) #14733
fix(cmake): Prevent overwriting of component properties in output file (IDFGH-13891) #14733
Conversation
👋 Hello viayie, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
While 'component_properties_text' correctly accumulated properties from all processed components, each iteration of the loop was overwriting the entire file content. Move the file(WRITE ...) call outside the loop to ensure all accumulated component properties are written once, preserving information for all components.
856edda
to
bdf0821
Compare
Hello @viayie , LGTM, thank you for this improvement! |
sha=bdf0821f976880a44100ccd140a6ce8bf8fef973 |
Description
While
component_properties_text
correctly accumulated properties from all processed components, each iteration of the loop was overwriting the entire file content.
Move the
file(WRITE ...)
call outside the loop to ensure all accumulated component properties are written once, preserving information for all components.Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: