Backport: fix(tools): Restore file permissions when extracting zip on unix (IDFGH-13773) #14633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
elipsitz
force-pushed
the
backport-zip-permissions
branch
from
32e7965 to
59f7f8d
Compare
github-actions
bot
changed the title
|
Hi @elipsitz, thank you for the contribution. You are right, the file permission must be restored, when it is used like this. I'll take a closer look. Thank you. |
espressif-bot
added
Status: Selected for Development
|
Thank you again @elipsitz for noticing us about the bug. We'll change the file format from |
espressif-bot
added
Status: Done
espressif-bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Changed the download file format for ninja tool from github with .zip file format to dl.espressif.com with .tar.gz file format. Closes #14633
espressif-bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
Changed the download file format for ninja tool from github with .zip file format to dl.espressif.com with .tar.gz file format. Closes #14633
|
Thanks for contribution again, changes have been merged with 8e11bd5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport 562bb67 to release/v5.1.
This is needed because f449357 added zip files for a tool (Ninja) on Linux/Mac to
release/v5.1, but the fix totools/idf_tools.pyis only in v5.2 and beyond.Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: