-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ESP32-P4 and ESP32-C5 models in the 'version' advanced console command output (IDFGH-13719) #14590
Conversation
the model ESP32P4 and ESP32C5 was unknown on version command in iperf example add model ESP32P4 and ESP32C5 which prints out model names now by the knowed model ESP32P4 = "ESP32-P4" ESP32C5 = "ESP32-C5" example app: iperf before: iperf> version IDF Version:v5.4-dev-2744-g59e1838270-dirty Chip info: model:Unknown cores:1 feature:/802.11bgn/BLE/External-Flash:8 MB revision number:0 iperf> after this add model is knowed now iperf> version IDF Version:v5.4-dev-2744-g59e1838270-dirty Chip info: model:ESP32-C5 cores:1 feature:/802.11bgn/BLE/External-Flash:8 MB revision number:0 iperf>
👋 Hello ESP32DE, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Not sure what's wrong - can it be the commit text "add model ESP32P4 ESP32C5" is not enough? If so, perhabs the comment text "feat(esp32): Add support for ESP32-P4 and ESP32-C5 models" is better? Feel free to change that like it is better or let me know please. thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change
add model ESP32P4 ESP32C5
to
feat(esp32): Add support for ESP32-P4 and ESP32-C5 models
thank you
Description
This PR enhances the
version
advanced console command output in the iPerf example to correctly display the model names for the ESP32-P4 and ESP32-C5 microcontrollers. The iPerf example now prints the ESP-IDF version number, chip information, and model name when the "version" command is executed.Previous Behavior
Before this change, the models ESP32-P4 and ESP32-C5 were displayed as "Unknown".
As an example, the execution before modification serves
The model is unknown.
New Behavior
After the modification, the model names are correctly displayed.
Here’s an example of the output when using the ESP32-C5:
The model ESP32C5 is now known and is now correctly printed with the model name ESP32-C5.
The code before
and the code after the change / add
Code Changes
The following cases were added to the
get_version
function:The ESP32-P4 and ESP32-C5 models have been added.
Example ESP32-C5
Attached Picture as Link
Related
Testing
Tested with ESP32-C5-DevKitC-1 and iPerf example and modification
successful printed out the right found model name
Checklist
Before submitting a Pull Request, please ensure the following: