Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): Timeout waiting for IP addrs in protocol_examples_common (IDFGH-13468) #14370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serpent213
Copy link
Contributor

@serpent213 serpent213 commented Aug 14, 2024

For example, in case a unique local address is preferred (via sdkconfig) but not available on the network, this patch prevents initialisation from hanging indefinitely.

Instead, we wait up to 10s for an IPv4 address and another 10s for the preferred type of IPv6 address. In case of timeout, a warning is logged and the program continues.

Copy link

github-actions bot commented Aug 14, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello serpent213, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 099c7c0

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2024

CLA assistant check
All committers have signed the CLA.

@serpent213 serpent213 force-pushed the examples_network_init branch 2 times, most recently from 4e36b9a to 55f0ed6 Compare August 14, 2024 19:52
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 14, 2024
@github-actions github-actions bot changed the title fix(examples): Timeout waiting for IP addresses in protocol_examples_common fix(examples): Timeout waiting for IP addresses in protocol_examples_common (IDFGH-13468) Aug 14, 2024
For example, in case a unique local address is preferred (via sdkconfig)
but not available on the network, this patch prevents initialisation
from hanging indefinitely.

Instead, we wait up to 10s for an IPv4 address and another 10s for the
preferred type of IPv6 address. In case of timeout, a warning is logged
and the program continues.
@serpent213 serpent213 force-pushed the examples_network_init branch from 55f0ed6 to 099c7c0 Compare August 14, 2024 20:01
@serpent213 serpent213 changed the title fix(examples): Timeout waiting for IP addresses in protocol_examples_common (IDFGH-13468) fix(examples): Timeout waiting for IP addrs in protocol_examples_common (IDFGH-13468) Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants