Fix(pthread): Added linux port with empty functions to make pthread cxx example build. (IDFGH-13424) (IDFGH-13433)

[cristianfunes79]

This change allows to build and run cxx pthread example located in esp-idf/examples/cxx/pthread.

[CLAassistant]

All committers have signed the CLA.

[github-actions]

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello cristianfunes79, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 2733099

[0xjakob]

Hi @cristianfunes79, thanks a lot for this pthread Linux target implementation. Don't worry about the amount of comments, they are mostly little things! The most important question we should answer before merging, is if it should be a pure stub implementation and only return some fixed values, or if there should be a bit of logic behind the functions. Both have their advantages and disadvantages, but I think a pure stub implementation is OK for now.

Regarding the comments in the code: they are mostly little things. We could fix them ourselves in an succeeding commit. But the more cleanly we can integrate your code, the better and the more code lines with your authorship will remain in the end.

We also have pre-commit to automate some of the chore work such as adding proper license headers. Same principle here: we can fix this ourselves, but then fewer lines with your authorship remain.

Please let us know what you think about the comments. Thanks!

[cristianfunes79]

Hi @cristianfunes79, thanks a lot for this pthread Linux target implementation. Don't worry about the amount of comments, they are mostly little things! The most important question we should answer before merging, is if it should be a pure stub implementation and only return some fixed values, or if there should be a bit of logic behind the functions. Both have their advantages and disadvantages, but I think a pure stub implementation is OK for now.

Regarding the comments in the code: they are mostly little things. We could fix them ourselves in an succeeding commit. But the more cleanly we can integrate your code, the better and the more code lines with your authorship will remain in the end.

We also have pre-commit to automate some of the chore work such as adding proper license headers. Same principle here: we can fix this ourselves, but then fewer lines with your authorship remain.

Please let us know what you think about the comments. Thanks!

IMO we can keep these as stubs, this unblocks pthread cxx example to be run on linux. I can work then in another PR to add functionality to these pthread functions. What do you think?

[0xjakob]

IMO we can keep these as stubs, this unblocks pthread cxx example to be run on linux. I can work then in another PR to add functionality to these pthread functions. What do you think?

Sounds good!

[0xjakob]

@cristianfunes79 One last thing: would you mind squashing the changes into one commit?

[0xjakob]

Great, we'll integrate this ASAP.

[0xjakob]

sha=27330993975d560971649b876b8739c005d33943

[0xjakob]

@cristianfunes79 We merged this PR internally. It should appear on github master soon. We had to rebase your commit due to some recent change in IDF. Your authorship will be retained, don't worry about that! However, this PR will be marked as "closed" instead of "merged".

[cristianfunes79]

@cristianfunes79 We merged this PR internally. It should appear on github master soon. We had to rebase your commit due to some recent change in IDF. Your authorship will be retained, don't worry about that! However, this PR will be marked as "closed" instead of "merged".

Great thanks, so can I pull from main now and start to work on adding functionality to this wrappers?