fix(tcp_transport): fix buffer overflow in ws connect (IDFGH-13247)

[johanstokking]

This fixes a buffer overflow in ws_connect when the HTTP response size equals or exceeds WS_BUFFER_SIZE (1K by default).

This easily reproducible with heap corruption detection (light impact is enough) and a large HTTP response received in one chunk and/or a header exceeding 1K.

Example:

D (24887) transport_ws: Read header chunk 1024, current header size: 1024
D (24897) transport_ws: HTTP status code is 404
E (24897) transport_ws: Sec-WebSocket-Accept not found
E (24897) websocket_client: esp_transport_connect() failed with -1, transport_error=ESP_OK, tls_error_code=0, tls_flags=0, esp_ws_handshake_status_code=404, errno=119
CORRUPT HEAP: Bad tail at 0x3fce54bc. Expected 0xbaad5678 got 0xbaad5600

assert failed: multi_heap_free multi_heap_poisoning.c:279 (head != NULL)

I observed this on:

• v5.2.2
• v5.3-rc1

Since v5.2.2 there have been some changes in this file (most notably 2267d4b) but the overflow is still here.

@gabsuren

[CLAassistant]

All committers have signed the CLA.

[github-actions]

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello johanstokking, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 0ba4646