Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openthread): fix RCP build to pass time sync and CSL options (IDFGH-13113) #14060

Closed
wants to merge 1 commit into from

Conversation

no2chem
Copy link
Contributor

@no2chem no2chem commented Jun 24, 2024

This PR fixes an issue where the menuconfig option OPENTHREAD_TIME_SYNC is set but OPENTHREAD_CONFIG_TIME_SYNC_ENABLE is never defined during a RCP build, resulting in an RCP build without time sync enabled. The same bug applies for CSL.

Fixes #14059

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello no2chem, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 93d9982

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 24, 2024
@github-actions github-actions bot changed the title fix(openthread): fix RCP build to pass time sync and CSL options fix(openthread): fix RCP build to pass time sync and CSL options (IDFGH-13113) Jun 24, 2024
@chshu
Copy link
Collaborator

chshu commented Jun 28, 2024

@no2chem Thank you for your contribution!

It's indeed a feature has not been supported in current SDK. CSL was introduced in Thread 1.2, but it has not yet seen widespread adoption in products. Time Sync is still an experimental feature and is not defined in the Thread specification.

Both the features are well supported by single SoC, and we will evaluate the feasibility of supporting them in RCP mode. Could you provide more details about your product use case? Is it based on ESP Thread BR?

@no2chem
Copy link
Contributor Author

no2chem commented Jun 30, 2024

Thanks @chshu -

We would like to use it with ESP thread BR - but the library is not open source so we are using ot-br-posix instead.

We've run into some stability issues with ESP thread BR so we're not as confident in using it because we can't fix it, but since the RCP should be agnostic to whether ESP thread BR or ot-br-posix is running on the NCP.

But both features work in RCP mode once the changes in this PR are applied, and #14089 is used to fix a bug in the 802154 state machine.

@chshu
Copy link
Collaborator

chshu commented Jun 30, 2024

@no2chem The change looks good with 2 minor comments, we will do some verification internally, and merge it then.

For any stability issue you encountered, please test again with the latest release/v5.1 branch, and feel free to file issues here: https://github.com/espressif/esp-thread-br.

@@ -123,6 +124,8 @@ if(CONFIG_OPENTHREAD_ENABLED)
"openthread/src/core/thread/network_diagnostic.cpp"
"openthread/src/core/thread/panid_query_server.cpp"
"openthread/src/core/thread/thread_netif.cpp"
"openthread/src/core/thread/thread_netif.cpp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's duplicate with previous line.

@@ -148,7 +148,7 @@
* `RadioSpinel` platform is used.
*
*/
#define OPENTHREAD_CONFIG_PLATFORM_RADIO_SPINEL_RX_FRAME_BUFFER_SIZE 1024
#define OPENTHREAD_LIB_SPINEL_RX_FRAME_BUFFER_SIZE 1024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new definition in OpenThread upsteam repo, but the OT submodule in IDF doesn't have the change yet. Could you please revert this change, and make sure it works with the current OT verion in IDF.

We will update the OT submodule in July.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread RCP build does not correctly pass through TIME_SYNC and CSL options (IDFGH-13112)
4 participants