Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allocate client->if_name twice in esp_http_client_init. (IDFGH-12992) #13943

Closed
wants to merge 1 commit into from

Conversation

fbp2m
Copy link
Contributor

@fbp2m fbp2m commented Jun 10, 2024

When if_name is specified in config an CONFIG_ESP_HTTP_CLIENT_ENABLE_HTTPS is set, client->if_name is allocated twice, and first one is never free.

When if_name is specified in config an CONFIG_ESP_HTTP_CLIENT_ENABLE_HTTPS is set, client->if_name is allocated twice, and first one is never free.
@CLAassistant
Copy link

CLAassistant commented Jun 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Fails
🚫
    The target branch for this pull request should be `master`.

    If you would like to add this feature to the release branch, please state this in the PR description and we will consider backporting it.

👋 Welcome fbp2m, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against d68f922

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 10, 2024
@github-actions github-actions bot changed the title Do not allocate client->if_name twice in esp_http_client_init. Do not allocate client->if_name twice in esp_http_client_init. (IDFGH-12992) Jun 10, 2024
@fbp2m fbp2m closed this Jun 10, 2024
@fbp2m
Copy link
Contributor Author

fbp2m commented Jun 10, 2024

New PR #13945 on master branch.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Duplicate This issue or pull request already exists and removed Status: Opened Issue is new labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Duplicate This issue or pull request already exists Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants