-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ulp): RVfplib as alternative floating point library for ULP RISC-V and LP Core (IDFGH-12981) #13932
Conversation
👋 Hello andylinpersonal, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@andylinpersonal Thanks for the contribution! Since this use-case is a bit more niche, I'm not sure we should include it in the ULP component (will be difficult for us to support all custom behavior users want) How do you think about this compromise: We could make it possible for users to have more direct control of the ULP build system, e.g. by letting users also provide their own cmakefile. Then use-cases like this could be achieved without IDF modification directly in the user's project. What do you think? (this would also allow setting |
Yes, a more flexible and less intrusive build system for ULP is what we demand. And it will be useful for the more complex use cases in the following ESP32-P4's LP subsystem. |
@andylinpersonal We've pushed a feature that should hopefully allow achieving stuff like this much easier for users. You can see an example [here])https://github.com/espressif/esp-idf/blob/master/examples/system/ulp/lp_core/build_system/main/ulp/CMakeLists.txt) I think with that we'll consider this ticket closed, feel free to reopen it if you still think RVfplib should be available by default for the lp-core. Or open a new ticket if you are unhappy/have any requests with regards to the ULP build-system. |
Add RVfplib as alternative soft-fp library, which might roughly reduce the code size by 1~3 KiB if only basic single precision arithmetics are used.
Though licensed under GPLv3 with library exeption, RVfplib has already been embedded into latest Cx, Hx and P4's rom code so it should not be an issue.