Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ledc_basic_example_main.c the order of initializers should match the declaration (IDFGH-11370) #12514

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

diplfranzhoepfinger
Copy link
Contributor

the order of initializers should match the declaration, to be able to also use this code in C++

the order of initializers should match the declaration, to be able to also use this code in C++
Copy link

github-actions bot commented Nov 2, 2023

Warnings
⚠️ The PR description looks very brief, please check if more details can be added.
⚠️

Some issues found for the commit messages in this MR:

  • the commit message Update ledc_basic_example_main.c appears to be a temporary or automatically generated message

Please consider updating these commit messages.


👋 Welcome diplfranzhoepfinger, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against 007c2b1

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 2, 2023
@github-actions github-actions bot changed the title Update ledc_basic_example_main.c Update ledc_basic_example_main.c (IDFGH-11370) Nov 2, 2023
@songruo songruo added the PR-Sync-Merge Pull request sync as merge commit label Nov 3, 2023
@songruo
Copy link
Collaborator

songruo commented Nov 3, 2023

sha=007c2b155e2506d432d92c540227fb470af12372

@diplfranzhoepfinger diplfranzhoepfinger changed the title Update ledc_basic_example_main.c (IDFGH-11370) Update ledc_basic_example_main.c the order of initializers should match the declaration (IDFGH-11370) Nov 3, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Nov 3, 2023
@espressif-bot espressif-bot merged commit ed5deb0 into espressif:master Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants