Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(components/esp_http_server): add task_caps configuration (IDFGH-11351) #12500

Closed
wants to merge 1 commit into from

Conversation

alonbl
Copy link
Contributor

@alonbl alonbl commented Oct 31, 2023

The HTTP server is not a critical component, it would be nice if we can control the task caps by using configuration.

Copy link

github-actions bot commented Oct 31, 2023

Messages
📖 Good Job! All checks are passing!

👋 Welcome alonbl, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

Generated by 🚫 dangerJS against a1227eb

@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 31, 2023
@github-actions github-actions bot changed the title change(components/esp_http_server): add task_caps configuration change(components/esp_http_server): add task_caps configuration (IDFGH-11351) Oct 31, 2023
The HTTP server is not a critical component, it would be nice if we can
control the task caps by using configuration.

Signed-off-by: Alon Bar-Lev <[email protected]>
@hmalpani
Copy link
Contributor

hmalpani commented Dec 4, 2023

sha=a1227eb016af16764438a48cbee144c16a2ebba8

@hmalpani hmalpani added the PR-Sync-Merge Pull request sync as merge commit label Dec 4, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Dec 4, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress labels Dec 14, 2023
@hmalpani
Copy link
Contributor

PR has been merged via commit: af79fe0

Closing this PR

@hmalpani hmalpani closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants