-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manager: fixing unwinding protocom endpoints, on prov_stop. (IDFGH-11307) #12459
Conversation
…les starting and stopping provisioning on a pre started http server
👋 Welcome kohait00, thank you for your first contribution to 📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project. Pull request review and merge process you can expectEspressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
|
Thanks for the contribution, @kohait00 - LGTM! |
sha=cf8a32102ba905a3f187bba1a5e5d38c047431f9 |
I am new to this contribution thingy :) |
Fix has been merged with 7c8663f. Thanks for the contribution! |
protocom endpoints added during wifi_prov_mgr_start_service arent currently removed during prov_stop_and_notify.
this is probably no problem, if protocom uses the httpd server itself, starting and stopping it on demand (not sure if it is designed for restart) and probaly the handlers will get removed in the process..
But: if protocom is provided with the handle of an external httpd server, it add the endpoints to it. they remain attached even if protocom is finished --> the endpoints need to be removed too.
This enables starting and stopping provisioning on a pre-started http server that is specified via wifi_prov_scheme_softap_set_httpd_handle
this effectively enables to start and stop provisioning at any time without turning off the http server
I very likely didn't cover everything involved, but as far, it works for me..
appreciate a short feedback on that