Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: fixing unwinding protocom endpoints, on prov_stop. (IDFGH-11307) #12459

Closed
wants to merge 1 commit into from

Conversation

kohait00
Copy link
Contributor

@kohait00 kohait00 commented Oct 25, 2023

protocom endpoints added during wifi_prov_mgr_start_service arent currently removed during prov_stop_and_notify.
this is probably no problem, if protocom uses the httpd server itself, starting and stopping it on demand (not sure if it is designed for restart) and probaly the handlers will get removed in the process..

But: if protocom is provided with the handle of an external httpd server, it add the endpoints to it. they remain attached even if protocom is finished --> the endpoints need to be removed too.

This enables starting and stopping provisioning on a pre-started http server that is specified via wifi_prov_scheme_softap_set_httpd_handle
this effectively enables to start and stop provisioning at any time without turning off the http server

I very likely didn't cover everything involved, but as far, it works for me..

appreciate a short feedback on that

…les starting and stopping provisioning on a pre started http server
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Messages
📖 Good Job! All checks are passing!

👋 Welcome kohait00, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

Generated by 🚫 dangerJS against cf8a321

@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 25, 2023
@github-actions github-actions bot changed the title manager: fixing unwinding protocom endpoints, on prov_stop. manager: fixing unwinding protocom endpoints, on prov_stop. (IDFGH-11307) Oct 25, 2023
@laukik-hase
Copy link
Collaborator

Thanks for the contribution, @kohait00 - LGTM!

@laukik-hase
Copy link
Collaborator

sha=cf8a32102ba905a3f187bba1a5e5d38c047431f9

@laukik-hase laukik-hase added the PR-Sync-Merge Pull request sync as merge commit label Oct 30, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: In Progress Work is in progress labels Oct 30, 2023
@kohait00
Copy link
Contributor Author

kohait00 commented Nov 3, 2023

sha=cf8a32102ba905a3f187bba1a5e5d38c047431f9

I am new to this contribution thingy :)
What does "Resolution unavailable" mean?

@mahavirj
Copy link
Member

Fix has been merged with 7c8663f. Thanks for the contribution!

@mahavirj mahavirj closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants