examples/bluedroid/gattc_demo.c - Use correct struct type (IDFGH-9899) #11214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the event is
ESP_GATTC_DIS_SRVC_CMPL_EVT
, then the struct should begattc_dis_srvc_cmpl_evt_param
as peresp-idf/components/bt/host/bluedroid/api/include/api/esp_gattc_api.h
Lines 243 to 249 in f404fe9
Currently it is using
gattc_cfg_mtu_evt_param
, which is defined asesp-idf/components/bt/host/bluedroid/api/include/api/esp_gattc_api.h
Lines 98 to 105 in f404fe9
Through coincidence, it does work since in memory the field
.conn_id
is at the same offset. However I think it is better to use the correct struct type , so it is less confusing to someone reading the example.