Skip to content

Commit

Permalink
fix(cmake): Rebuild on changes in sdkconfig.defaults
Browse files Browse the repository at this point in the history
When you change sdkconfig.defaults, sdkconfig is not updated and a rebuild is
not triggered. This commit fixes that by adding the files to the target.
  • Loading branch information
MathyV committed Jul 16, 2024
1 parent 5ca9f2a commit 3ecbb4d
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions tools/cmake/kconfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,17 @@ function(__kconfig_generate_config sdkconfig sdkconfig_defaults)
# When sdkconfig file changes in the future, trigger a cmake run
set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${sdkconfig}")

# Or if any of the sdkconfig.defaults files change
if(sdkconfig_defaults)
foreach(sdkconfig_default ${sdkconfig_defaults})
set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${sdkconfig_default}")

if(EXISTS "${sdkconfig_default}.${idf_target}")
set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${sdkconfig_default}.${idf_target}")
endif()
endforeach()
endif()

# Ditto if either of the generated files are missing/modified (this is a bit irritating as it means
# you can't edit these manually without them being regenerated, but I don't know of a better way...)
set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${sdkconfig_header}")
Expand Down

0 comments on commit 3ecbb4d

Please sign in to comment.