fix(esp_lvgl_port): Make sure LVGL is initialize at the end of lvgl_port_init() call #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tore-espressif This is not good fix. There is reason, why init is called from LVGL port task. It should be in the same task like |
tore-espressif
force-pushed
the
fix/lvgl_port_priority_bug
branch
from
9fdbc3a to
75a14a9
Compare
Fixed by FreeRTOS task notifications |
tore-espressif
force-pushed
the
fix/lvgl_port_priority_bug
branch
from
75a14a9 to
f536943
Compare
espzav
approved these changes
Jan 10, 2025
tore-espressif
force-pushed
the
fix/lvgl_port_priority_bug
branch
from
f536943 to
91b65ff
Compare
Test Results 15 files 15 suites 5m 32s ⏱️ Results for commit 2877ed4. ♻️ This comment has been updated with latest results. |
Previously, we initialized LVGL in the new LVGL handling task. If lvgl_port_init() was called from high priority task, it could return with uninitialized LVGL. Closes #455
tore-espressif
force-pushed
the
fix/lvgl_port_priority_bug
branch
from
91b65ff to
2877ed4
Compare
3 tasks
tore-espressif
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we initialized LVGL in the new LVGL handling task. If lvgl_port_init() was called from high priority task, it could return with uninitialized LVGL.
Closes #455
Closes #475