-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Single workflow for GitHub and Pypi release #3
base: master
Are you sure you want to change the base?
Conversation
👋 Hello tomassebestik, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small notes. Otherwise LGTM!
echo "VERSION=$version" >> $GITHUB_OUTPUT | ||
|
||
- name: Install dependencies | ||
run: python -m pip install pip czespressif --upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, you are installing dependencies from the previous version.
I believe it should be python -m pip install pip . --upgrade
**/*.whl | ||
**/*.tar.gz | ||
|
||
- name: Push release to Pypi - upload builds to PYPI.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, it should be stylized as PyPI
run: python -m pip install pip czespressif --upgrade | ||
|
||
- name: Generate Release notes from Changelog | ||
run: cz changelog ${{ steps.get_version.outputs.VERSION }} --template="RELEASE_NOTES.md.j2" --file-name="Release_notes.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Release_notes.md
with a first capital letter seems a little unusual
- os: macos-12 | ||
arch: amd64 # macOS 11 should be used for arm64 (Apple Silicon) | ||
- os: macos-14 | ||
arch: amd64 # macOS 11 should be used for arm64 (Apple Silicon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused by this, the versions do not seem to match in the comments and code. Another thing is that it seems that it will build for arm64 macOS twice - on version 12 and 14, but not even once for amd64.
Description
This PR is adding single workflow that creates release:
Others
Notes