Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize path regex #44

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: normalize path regex #44

merged 2 commits into from
Dec 9, 2024

Conversation

hfudev
Copy link
Member

@hfudev hfudev commented Apr 18, 2024

only error/warning have [ERROR IDENTIFIER]

@hfudev hfudev self-assigned this Apr 18, 2024
@hfudev
Copy link
Member Author

hfudev commented Apr 18, 2024

seems like the codereport requires pygments<2.12, but idf requires 'pygments<3.0.0,>=2.13.0'

@dobairoland
Copy link
Collaborator

@radimkarnis PTAL

Copy link
Collaborator

@radimkarnis radimkarnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

only error/warning have [ERROR IDENTIFIER]
@dobairoland dobairoland force-pushed the fix/normalize_path_regex branch from 938cc10 to 4f2b56b Compare December 9, 2024 11:57
@dobairoland
Copy link
Collaborator

Thanks @radimkarnis. I rebased this to see if the checks pass. I'm merging it now.

@dobairoland dobairoland merged commit 0e1b4f8 into master Dec 9, 2024
4 checks passed
@dobairoland dobairoland deleted the fix/normalize_path_regex branch December 9, 2024 12:04
@hfudev
Copy link
Member Author

hfudev commented Dec 11, 2024

thank you for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants