-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esp32): Added a new device(xiao esp32s3 plus) #10768
base: master
Are you sure you want to change the base?
Conversation
👋 Hello is-qian, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@is-qian Probably last error that I did not see before, is the variant folder name vs the variant name in boards.txt. You need to fix this:
Variant folder name: XIAO_ESP32S3_Plus
In Boards.txt XIAO_ESP32S3_PLUS.build.variant=XIAO_ESP32S3_PLUS
The name must be the same and its case sensitive.
Thank you for the reminder, I have fixed this issue. |
572c6f3
to
506578b
Compare
Description of Change
feat(esp32): Added a new device from Seeed: Xiao ESP32S3 Plus