Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextion] Adds a command pacer with command_spacing attribute #4499

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

edwardtfn
Copy link
Contributor

Description:

This introduces a "pacer" for the communication with the Nextion display, with the main objective to reduce the chances of a buffer overflow on Nextion side.
The buffer overflow can be quite critical, as it removes it's queue, while the component on ESPHome keeps waiting for responses for those removed commands, so a way to control the communication pace and give to users a chance to reduce the chances of a buffer overflow by compromising (a bit?) the performance which many times wouldn't be perceived by end users.
As default I'm setting the pace to 0ms, to keep this transparent to existing installation, although I would highly recommend the use of at least 10ms. Anyhow, users can increase this dynamically, if a buffer overflow happens.

Related issue (if applicable): N/A

Pull request in esphome with YAML changes (if applicable): esphome/esphome#7948

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit e13b9fe
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/675896b635d1900008bb02bf
😎 Deploy Preview https://deploy-preview-4499--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant