Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lean style math symbol completions #107

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Conversation

johannesCmayer
Copy link
Contributor

Add math symbol completions based on the VScode lean extension.

@AucaCoyan
Copy link
Member

Hello! The CI found an error

Validating package: lean-symbols... Found 1 errors:
Check: incoherent_path
->: package name mismatch in package lean-symbols: the path indicates that the name is lean-symbols, but the manifest calls it espanso-lean-symbols

Would you kindly fix it? It's almost there 😄

@smeech smeech mentioned this pull request May 2, 2024
Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A straightforward text replacement package.
No cmd:, script, shell or risky code.
Could safely be merged.

@smeech smeech added the invalid This doesn't seem right label Jun 1, 2024
@johannesCmayer
Copy link
Contributor Author

I have now updated the package to incorporate all of the fixes. I will make another pull request because I actually regenerated all completions to the latest completions, and also removed all my custom modifications such that it is actually exactly the lean completions.

My main question is whether it makes sense to put the 30-line Python script that generates the completions in the package. It's not required, and it's not ever used, but it also seems like the natural place to put it.

@smeech
Copy link
Collaborator

smeech commented Jun 16, 2024

I have now updated the package to incorporate all of the fixes. I will make another pull request because I actually regenerated all completions to the latest completions, and also removed all my custom modifications such that it is actually exactly the lean completions.

My main question is whether it makes sense to put the 30-line Python script that generates the completions in the package. It's not required, and it's not ever used, but it also seems like the natural place to put it.

That seems reasonable. 30 lines isn't large, it may be of interest, and I suppose it would enable users to update the list if it changed, although you might update the package with a new version if that occurred.
Include some explanatory text in your new README.md, perhaps.

@johannesCmayer johannesCmayer requested a review from smeech June 17, 2024 11:29
Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - this is coming together nicely.
Just a couple of new comments - sorry ☹️ !

@johannesCmayer johannesCmayer requested a review from smeech June 17, 2024 20:19
Slight amendment for users.
@smeech smeech merged commit e879872 into espanso:main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants