-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lean style math symbol completions #107
Conversation
Hello! The CI found an error
Would you kindly fix it? It's almost there 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A straightforward text replacement package.
No cmd:
, script
, shell
or risky code.
Could safely be merged.
I have now updated the package to incorporate all of the fixes. I will make another pull request because I actually regenerated all completions to the latest completions, and also removed all my custom modifications such that it is actually exactly the lean completions. My main question is whether it makes sense to put the 30-line Python script that generates the completions in the package. It's not required, and it's not ever used, but it also seems like the natural place to put it. |
That seems reasonable. 30 lines isn't large, it may be of interest, and I suppose it would enable users to update the list if it changed, although you might update the package with a new version if that occurred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - this is coming together nicely.
Just a couple of new comments - sorry
…ile instead; fix manifest version
Slight amendment for users.
Add math symbol completions based on the VScode lean extension.