Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI to use ESP-IDF 5.4 #365

Merged
merged 2 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,6 @@ jobs:
- name: Build Examples
uses: espressif/esp-idf-ci-action@v1
with:
esp_idf_version: release-v5.2
esp_idf_version: release-v5.4
target: ${{ matrix.test.target }}
path: ${{ matrix.test.path }}
4 changes: 2 additions & 2 deletions .github/workflows/static_analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
# Do not build the project and do not use cmake to generate compile_commands.json
use_cmake: false

# Use the 5.2 release version since it's what we build with
esp_idf_version: release/v5.2
# Use the 5.4 release version since it's what we build with
esp_idf_version: release/v5.4

# (Optional) cppcheck args
cppcheck_args: -i$GITHUB_WORKSPACE/lib -i$GITHUB_WORKSPACE/external -i$GITHUB_WORKSPACE/components/binary-log/detail -i$GITHUB_WORKSPACE/components/esp_littlefs -i$GITHUB_WORKSPACE/components/esp-nimble-cpp -i$GITHUB_WORKSPACE/components/hid-rp/include/hid -i$GITHUB_WORKSPACE/components/lvgl -i$GITHUB_WORKSPACE/components/esp-dsp --force --enable=all --inline-suppr --inconclusive --platform=mips32 --suppressions-list=$GITHUB_WORKSPACE/suppressions.txt
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# Espressif++ (ESPP)

This is the repository for some c++ components developed for the
[ESP-IDF](https://github.com/espressif/esp-idf) framework.
[ESP-IDF](https://github.com/espressif/esp-idf) framework. Specifically we are
targeting `ESP-IDF 5.4` currently.

> NOTE: This repo attempts to stay up to date with ESP-IDF. This means that the
> code within may not be supported on older ESP-IDF targets.

Each component has an `example` folder which contains c++ code showing how to
use the component and which has a README including instructions for how to run
Expand Down
2 changes: 1 addition & 1 deletion components/binary-log/detail
7 changes: 6 additions & 1 deletion components/file_system/example/main/file_system_example.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,14 @@ extern "C" void app_main(void) {
logger.info("Wrote '{}' to {}", file_contents, sub_file.string());

// list files in a directory
// NOTE: if we're using ESP-IDF < 5.4, we can't use directory_iterator
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 0)
logger.info("Directory iterator:");
#else
logger.warn(
"NOTE: directory_iterator is not implemented in esp-idf right now :( (as of v5.2.2)");
"NOTE: directory_iterator is not implemented in esp-idf less than 5.4, the following "
"listing will not work.");
#endif
// NOTE: directory_iterator is not implemented in esp-idf right now :(
// directory_iterator can be iterated using a range-for loop
for (auto const &dir_entry : fs::recursive_directory_iterator{sandbox, ec}) {
Expand Down