Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/display task stack config #143

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

finger563
Copy link
Contributor

Description

  • Update display API to support configuring task stack size
  • Reduced default stack size from 8192 to 4096 since task monitor showed >4k unused stack

Motivation and Context

Different applications may have different stack size needs for the display, and the default stack size was wasteful (8k when less than 4k is needed).

How has this been tested?

Building and running within the https://github.com/esp-cpp/esp-box-emu project

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update display API to support configuring task stack size
* Reduced default stack size from 8192 to 4096 since task monitor showed >4k unused stack
@finger563 finger563 added enhancement New feature or request display drivers labels Jan 16, 2024
@finger563 finger563 merged commit 17f1e3c into main Jan 16, 2024
39 checks passed
@finger563 finger563 deleted the feature/display-task-stack-config branch January 16, 2024 21:34
Copy link

✅Static analysis result - no issues found! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display drivers enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant