Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format helpers use fmt::format_to to prevent collision with std::format_to if <format> is used #128

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Nov 15, 2023

Description

fix(fmt): updated format helpers to explicitly use fmt::format_to to prevent collision with std::format_to if is included (like possible with later idfs)

Motivation and Context

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…prevent collision with std::format_to if <format> is included (like possible with later idfs)
@finger563 finger563 merged commit b048d77 into main Nov 15, 2023
47 checks passed
@finger563 finger563 deleted the fix/fmt-scope branch November 15, 2023 19:00
@finger563 finger563 added bug Something isn't working format labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant