Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test with ESLint instead of CLIEngine when available #198

Merged
merged 1 commit into from
Nov 30, 2021
Merged

test: test with ESLint instead of CLIEngine when available #198

merged 1 commit into from
Nov 30, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

As asked by @btmills in #195 (comment)

@nzakas
Copy link
Member

nzakas commented Nov 24, 2021

Tests are failing

btmills
btmills reviewed Nov 28, 2021
View reviewed changes
tests/lib/plugin.js Outdated Show resolved Hide resolved
btmills
btmills requested changes Nov 28, 2021
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we're one typo fix away from all tests passing 🤞 If that's true, LGTM once that change is made!

tests/lib/plugin.js Outdated Show resolved Hide resolved
@MichaelDeBoey
Copy link
Contributor Author

@btmills All tests are green now 🥳🎉

btmills
btmills approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, no implementation changes needed to work with the ESLint API! Thanks for proving that in these tests.

@btmills btmills merged commit b695396 into eslint:main Nov 30, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-3 branch November 30, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btmills btmills btmills approved these changes

Assignees
No one assigned
Labels
accepted chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @nzakas @btmills