chore: test all supported ESLint versions #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MichaelDeBoey!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
MichaelDeBoey
changed the title
|
Hi @MichaelDeBoey!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
MichaelDeBoey
force-pushed
the
patch-1
branch
from
983aa87
to
b593730
Compare
btmills
reviewed
Nov 23, 2021
MichaelDeBoey
force-pushed
the
patch-1
branch
from
b593730
to
80a0f68
Compare
btmills
reviewed
Nov 23, 2021
MichaelDeBoey
force-pushed
the
patch-1
branch
from
80a0f68
to
1f8472d
Compare
|
Looks like there may be an issue on Mac CI. |
|
@nzakas all tests are green |
btmills
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
LGTM, thanks @MichaelDeBoey! I'll give others another day to review before merging.
nzakas
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked by @btmills in #195 (comment)