-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: blog: ESLint Community org announcement #402
feat: blog: ESLint Community org announcement #402
Conversation
👷 Deploy request for es-eslint pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for new-eslint ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
4b70717
to
11aa924
Compare
CI is failing because the author info is not available. @MichaelDeBoey pls add your details in all_authors.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together. I cleaned up some of the wording and left some other comments.
Please move this into the drafts folder, as we aren't sure when this will be published yet.
Also, this file isn't building correctly, all of the CI is failing. Please double-check that.
d097c84
to
155f68f
Compare
477c031
to
b1c19ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up, it's looking a lot better. I've left some minor stylistic suggestions (ampersands shouldn't be used in prose) and some other general comments. I think we want to be careful to put our best foot forward with this announcement and be clear on the role of eslint-community. I left some comments to that effect.
b1c19ba
to
e12ab91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for @nzakas approval.
@MichaelDeBoey can you please update the blog post? Let me know if you have any questions about my last round of feedback. Thanks! |
@MichaelDeBoey just checking in again. I'd really like to get this finished and posted. Can you update it please? |
@nzakas I've been away for some time, so sorry for the late response. I'll try to take some time later this week to look into updating the blogpost. |
@MichaelDeBoey sounds good. thanks! |
e12ab91
to
c7f424c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I left some suggestions on how we can further clarify things.
We still need a conclusion for this post, as well.
Thanks! We are close!
d61970a
to
771af00
Compare
771af00
to
57874f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm going to clean up some of the formatting and then I'll publish it.
Prerequisites checklist
What is the purpose of this pull request?
Adding a blogpost to announce the official ESLint Community org
What changes did you make?
I added a blogpost to announce the official ESLint Community org
Related Issues
N/A
Is there anything you'd like reviewers to focus on?
Spelling, grammar & if everything's included that @nzakas wants to include.