Numerous resource leaks fixed #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix enif_resource leaks on socket and context add destructors assert in destructors that close or term was called fix deadlock on socket close immediately after term
zmq_term will NOT close sockets. It will block until sockets are closed with zmq_close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch erlzmq was leaking enif_resource which prevented closed sockets and terminated context to be garbage collected due to unbalanced enif_resource_keep calls. Moreover, it leaked an unjoined thread. All threads created by https://erlang.org/doc/man/erl_driver.html#erl_drv_thread_create must be joined before unloading driver.
One of the tests was also invalid - it incorrectly assumed that zmq_term will close all sockets. See http://api.zeromq.org/master:zmq-term