Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tool HESS to 0.0.1+galaxy0 #82

Merged
merged 25 commits into from
Feb 19, 2024

Conversation

dsavchenko
Copy link
Collaborator

No description provided.

@dsavchenko
Copy link
Collaborator Author

@bgruening is the linting of the script files really mandatory in CI/CD?
I'm trying to do my best to automatically restyle the code, which is "crowdsourced" from notebooks. But there are still some issues, especially in imports sorting.
Are we allowed to modify the workflow to ignore some of them?

@bgruening
Copy link
Collaborator

In your case it probably does not make sense. For us if the code is handwritten its better to follow some standards.
If you like just use https://github.com/psf/black to reformat it or drop the CI.

@dsavchenko
Copy link
Collaborator Author

dsavchenko commented Feb 16, 2024

OK, thank you! I actually do some code formatting using black, autoflake and isort. Still, some formatting issues left. I will then modify the CI so that flake failure is not blocking for autogenerated tools #88.

@dsavchenko dsavchenko mentioned this pull request Feb 16, 2024
1 task
@volodymyrss volodymyrss self-requested a review February 19, 2024 09:30
@dsavchenko dsavchenko merged commit 2991f65 into main Feb 19, 2024
13 of 14 checks passed
@volodymyrss
Copy link
Contributor

I think it's pushed to toolshed successfully! https://toolshed.g2.bx.psu.edu/view/astroteam/hess_astro_tool/02e4bb4fa10c

@volodymyrss
Copy link
Contributor

You may wan to ask to add it like usegalaxy-eu/usegalaxy-eu-tools#594

@bgruening bgruening deleted the auto-update-galaxy-tool-hess-v0.0.1-galaxy0 branch February 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants