-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action for updating archives list #107
Github action for updating archives list #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There often occurs the linting problem with unavailable urls in tool description (help section, I suppose). Could we also deal with it in this action?
@francoismg do we have something to finish and conversations to resolve here? Could you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
takes 10 min to complete and a bit more to check.
Actions need to be granted the right to create pull request in settings -> actions |
Ok, done. Could you please check now? |
seems all good #111 I should just make sure that it will only contains the commits with the list update otherwise it will always try to push the new action to main |
let's do it Thursday night once a week |
@dsavchenko could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of the tool needs to be updated here (discussion above)
Tool version update is working on my local test setup, just need to rework fetch_archives script so the sample file only contains columns description and first row and then will test it against the real repo |
Thanks for the update, @francoismg , could you push your WIP here? |
WIP has been updated to work with pull request and is pushed, should work but had a pyvo exception last few runs so couldn't validate everything will try again in a moment |
Everything is working on my side but I can't test it directly here cause workflow dispatch is not available (not sure if permission issue or something else), we can try to merge and see if it's working if it's ok with you @volodymyrss |
As discussed in #64