Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action for updating archives list #107

Merged
merged 11 commits into from
Oct 16, 2024

Conversation

francoismg
Copy link
Contributor

As discussed in #64

@francoismg
Copy link
Contributor Author

@volodymyrss @dsavchenko

Copy link
Collaborator

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There often occurs the linting problem with unavailable urls in tool description (help section, I suppose). Could we also deal with it in this action?

.github/workflows/update-archives-list.yml Show resolved Hide resolved
fetch_archives.py Show resolved Hide resolved
@volodymyrss
Copy link
Contributor

@francoismg do we have something to finish and conversations to resolve here? Could you please have a look?

Copy link
Contributor

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

takes 10 min to complete and a bit more to check.

@francoismg francoismg closed this May 31, 2024
@francoismg francoismg reopened this May 31, 2024
@francoismg
Copy link
Contributor Author

Actions need to be granted the right to create pull request in settings -> actions

@volodymyrss
Copy link
Contributor

Actions need to be granted the right to create pull request in settings -> actions

Ok, done. Could you please check now?

@francoismg francoismg closed this May 31, 2024
@francoismg francoismg reopened this May 31, 2024
@francoismg
Copy link
Contributor Author

Actions need to be granted the right to create pull request in settings -> actions

Ok, done. Could you please check now?

seems all good #111

I should just make sure that it will only contains the commits with the list update otherwise it will always try to push the new action to main

@volodymyrss
Copy link
Contributor

let's do it Thursday night once a week

@volodymyrss
Copy link
Contributor

@dsavchenko could you please review?

Copy link
Collaborator

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of the tool needs to be updated here (discussion above)

@francoismg
Copy link
Contributor Author

The version of the tool needs to be updated here (discussion above)

Tool version update is working on my local test setup, just need to rework fetch_archives script so the sample file only contains columns description and first row and then will test it against the real repo

@volodymyrss
Copy link
Contributor

Thanks for the update, @francoismg , could you push your WIP here?

@francoismg
Copy link
Contributor Author

Thanks for the update, @francoismg , could you push your WIP here?

WIP has been updated to work with pull request and is pushed, should work but had a pyvo exception last few runs so couldn't validate everything will try again in a moment

@francoismg
Copy link
Contributor Author

Everything is working on my side but I can't test it directly here cause workflow dispatch is not available (not sure if permission issue or something else), we can try to merge and see if it's working if it's ok with you @volodymyrss

@volodymyrss volodymyrss merged commit 4f928d7 into main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants