Skip to content

Commit

Permalink
nit bits
Browse files Browse the repository at this point in the history
  • Loading branch information
ese-erigha committed Apr 2, 2021
1 parent 4792a20 commit 4dd667e
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 22 deletions.
20 changes: 20 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,26 @@
"prettify": "prettier --write **/*.{ts,tsx,js,jsx,json}",
"format": "prettier --write 'src/**/*.{ts,tsx,scss,css,json}'"
},
"jest": {
"coveragePathIgnorePatterns": [
"node_modules",
"test-config",
"interfaces",
"jestGlobalMocks.ts",
".module.ts",
"<rootDir>/src/App.tsx",
"<rootDir>/src/index.tsx",
"<rootDir>/src/reportWebVitals.ts"
],
"coverageThreshold": {
"global": {
"statements": 80,
"branches": 80,
"functions": 80,
"lines": 80
}
}
},
"husky": {
"hooks": {
"pre-commit": "lint-staged"
Expand Down
8 changes: 4 additions & 4 deletions src/components/__tests__/SearchForm.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { render, screen } from '@testing-library/react';
import { render, screen, waitFor } from '@testing-library/react';
import { Router } from 'react-router-dom';
import SearchForm from 'components/SearchForm';
import { createMemoryHistory } from 'history';
Expand All @@ -15,7 +15,7 @@ const renderWithRoute = (path: string) => {
);
};

describe('NavBar', () => {
describe('SearchForm', () => {
test('should render search form with empty input on movies route', () => {
renderWithRoute('/movies');
const input = screen.getByRole('textbox') as HTMLInputElement;
Expand All @@ -32,14 +32,14 @@ describe('NavBar', () => {
expect(input.value).toEqual(query);
});

test('should change input value when user types', () => {
test('should change input value when user types', async () => {
const query = 'red';
renderWithRoute('/movies');
const input = screen.getByRole('textbox') as HTMLInputElement;
expect(input).toBeInTheDocument();
expect(input.value).toEqual('');

userEvent.type(input, query);
expect(input.value).toEqual(query);
await waitFor(() => expect(input.value).toEqual(query));
});
});
2 changes: 0 additions & 2 deletions src/hoc/__tests__/withErrorHandler.integration.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,5 @@ describe('Integration test between useHttpErrorHandler hook and withErrorHandler
expect(screen.queryByTestId('close-button')).not.toBeInTheDocument();
expect(screen.queryByText('Error')).not.toBeInTheDocument();
expect(screen.queryByText(`${axiosError.message}`)).not.toBeInTheDocument();

screen.debug();
});
});
32 changes: 16 additions & 16 deletions src/pages/__tests__/Home.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,22 @@ describe('Home', () => {
mockFetchGenres.mockResolvedValueOnce(genres);
mockGetMovies.mockResolvedValueOnce(moviesResponse);
});
// test('should render loading spinner', async () => {
// const history = createMemoryHistory();
// history.push(`/movies/${category}`);
// render(
// <HelmetProvider>
// <AppContext.Provider value={{ genres: [], setGenres }}>
// <Router history={history}>
// <Route path={route.home}>
// <Home />
// </Route>
// </Router>
// </AppContext.Provider>
// </HelmetProvider>
// );
// await waitFor(() => expect(screen.getByTestId('spinner')).toBeInTheDocument());
// });
test('should render loading spinner', async () => {
const history = createMemoryHistory();
history.push(`/movies/${category}`);
render(
<HelmetProvider>
<AppContext.Provider value={{ genres: [], setGenres }}>
<Router history={history}>
<Route path={route.home}>
<Home />
</Route>
</Router>
</AppContext.Provider>
</HelmetProvider>,
);
await waitFor(() => expect(screen.getByTestId('spinner')).toBeInTheDocument());
});

test('should render movie list', async () => {
const history = createMemoryHistory();
Expand Down

0 comments on commit 4dd667e

Please sign in to comment.