Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: choice pages #11

Merged
merged 9 commits into from
Jan 22, 2024
Merged

feat: choice pages #11

merged 9 commits into from
Jan 22, 2024

Conversation

mildrrnt
Copy link
Contributor

@mildrrnt mildrrnt commented Jan 12, 2024

Change made

  • Bug fixes
  • New features
  • Breaking changes

Describe what you have done

  • Add pages that have choices, both scored and unscored.
  • Implement TapLast component with logic for determine the url location according to the highest value in scores.
    Edit: 19/01/2024
    • Implement this logic into Tap component instead.
    • Change the logic from finding the highest values from the scores in Local Storage to finding the highest percentage of score compared to the possible max scores.

New Features

  • Determine user's final result.

@mildrrnt mildrrnt requested a review from shalluv January 12, 2024 08:23
@mildrrnt mildrrnt self-assigned this Jan 12, 2024
@shalluv
Copy link
Member

shalluv commented Jan 16, 2024

These tasks are dependent on the components branch, correct? So, once the other tasks are completed, I'll revisit here.

Copy link
Member

@shalluv shalluv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! You've done an amazing work.

Small note: when naming files in pages, the name becomes routes. Therefore, use kebab-case and avoid capitalization.

@shalluv shalluv merged commit d447810 into dev Jan 22, 2024
1 check passed
@shalluv shalluv deleted the worranittha/gea-12-choices branch January 22, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants