Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Bump require CMake version #590

Merged
merged 2 commits into from
Jan 13, 2025
Merged

CMake: Bump require CMake version #590

merged 2 commits into from
Jan 13, 2025

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Jan 13, 2025

Avoids the cmake<3.10 deprecation message and simplifies some code
cmake 3.13 is still old enough (debian 10)

@bluescarni
Copy link
Member

@jschueller cheers!

The sanitizer issue on the circleci build is due to this:

google/sanitizers#1614

Basically, recent ubuntu versions increased the sysctl vm.mmap_rnd_bits setting from 28 to 32 bits, and this bothers older versions of the address sanitizer. In another project I tried unsuccessfully to change the setting on circleci - but it would not let me due IIRC to some docker security policy. Eventually I just moved the sanitizer-enabled builds on github actions.

I can merge this for the time being (unless you feel motivated and want to help out with the move of the build to GHA :) )

@jschueller
Copy link
Contributor Author

jschueller commented Jan 13, 2025

I'm not sure I can help for this one sorry, at least I fixed the arm build

@bluescarni bluescarni merged commit ac7b6d2 into esa:master Jan 13, 2025
5 of 6 checks passed
@jschueller jschueller deleted the bump branch January 14, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants