Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for JSON#parse and JSON#stringify. #348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tests for JSON#parse and JSON#stringify. #348

wants to merge 1 commit into from

Conversation

Xotic750
Copy link
Contributor

@Xotic750
Copy link
Contributor Author

Need to cross check and see if JSON3 has any other tests that are not included here, but it's a good start to test native JSON and JSON2 on top of es5-shim.
https://github.com/bestiejs/json3/blob/master/test/test_json3.js
At least it will make it easier to judge what is going on, and make choices.

@Xotic750 Xotic750 force-pushed the json branch 2 times, most recently from cb2dac4 to bdbdbbc Compare November 18, 2015 10:19
@Xotic750
Copy link
Contributor Author

This was a just quick port and still needs some work to make the errors readable and stuff (jasminize it, is that a real word? :) ). I'll work on it and improve it somewhat.

@Xotic750 Xotic750 force-pushed the json branch 3 times, most recently from 33ab741 to 06487fd Compare November 18, 2015 23:06
@Xotic750
Copy link
Contributor Author

That should have improved the error messages. :)

@Xotic750 Xotic750 force-pushed the json branch 8 times, most recently from c575356 to 98234b2 Compare November 19, 2015 02:23
@Xotic750 Xotic750 force-pushed the json branch 2 times, most recently from 9453a7b to 9fbc1d1 Compare December 27, 2015 06:08
@Xotic750 Xotic750 mentioned this pull request Jan 26, 2016
Merged
@ljharb
Copy link
Member

ljharb commented Apr 22, 2022

@Xotic750 can you please check the "allow edits" checkbox on the RHS of the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xotic750 @ljharb